Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement k8s plugin's FetchDefinedStages and BuildQuickSyncStages #5223

Merged
merged 11 commits into from
Sep 25, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 24, 2024

What this PR does / why we need it:

This PR implements part of the Kubernetes plugin, FetchDefinedStages and BuildQuickSyncStages.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 22.82%. Comparing base (083c810) to head (e57ffc4).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes/deployment/server.go 0.00% 28 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5223      +/-   ##
==========================================
+ Coverage   22.81%   22.82%   +0.01%     
==========================================
  Files         419      419              
  Lines       45304    45319      +15     
==========================================
+ Hits        10334    10344      +10     
- Misses      34174    34180       +6     
+ Partials      796      795       -1     
Flag Coverage Δ
22.82% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only v1 is affected

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@Warashi Warashi merged commit fb46bdb into master Sep 25, 2024
16 of 17 checks passed
@Warashi Warashi deleted the k8s-plugin branch September 25, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants